[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: "easingCurve" property now belongs to
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-04-23 16:04:23
Message-ID: 20100423160423.12893.17093 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3783/#review5184
-----------------------------------------------------------


yes, because it's not binary compat with 4.4 we can't do this. the best we can do is \
mark these methods for moving in kde5, though other animations may want to take \
advantage of the easing curve as well.

- Aaron


On 2010-04-22 23:14:48, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3783/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 23:14:48)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson \
> Cavalcanti. 
> 
> Summary
> -------
> 
> Now that Plasma animations are split between eased and non-eased animations, the \
> "easingCurve" property should belong to Plasma::EasingAnimation class, which makes \
> more sense. However, this breaks binary compatibility :/ 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/plasma/animations/animation.h 1117000 
> trunk/KDE/kdelibs/plasma/animations/animation.cpp 1117000 
> trunk/KDE/kdelibs/plasma/animations/easinganimation.cpp 1117000 
> trunk/KDE/kdelibs/plasma/animations/easinganimation_p.h 1117000 
> 
> Diff: http://reviewboard.kde.org/r/3783/diff
> 
> 
> Testing
> -------
> 
> Everything worked just fine after compile + install (easing curves worked as \
> should). 
> 
> Thanks,
> 
> Bruno
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]