[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Implemented Plasma::GaussianBlur effect
From:       Richard Moore <rich () kde ! org>
Date:       2010-04-20 16:29:56
Message-ID: m2o5491a5151004200929y63354024rc561a9cb3c9f84be () mail ! gmail ! com
[Download RAW message or body]

On Tue, Apr 20, 2010 at 4:49 PM, Aaron Seigo <aseigo@kde.org> wrote:
>> On 2010-04-20 15:18:25, Richard Moore wrote:
>> > Missing d pointer
>> > When not move the function that allocates the gauss vector into the private object?
>> >
>
> it isn't a public class (none of the animations are), so a dptr isn't actually needed in this case :)

It looked to me as if the intention was to have a reusable BlurEffect
that was a public QGraphicsEffect, with the animation merely using it.
If so then that would need the effect class to be public. Obviously if
the only user is the animation then my comments don't apply.

Rich.
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]