[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add libqalculate support to calculator runner
From:       "Matteo Agostinelli" <agostinelli () gmail ! com>
Date:       2010-04-15 8:23:28
Message-ID: 20100415082328.17755.84241 () localhost
[Download RAW message or body]



> On 2010-04-12 06:55:52, Alessandro Diaferia wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp, \
> > line 45 <http://reviewboard.kde.org/r/3483/diff/1/?file=22478#file22478line45>
> > 
> > I know nothing about libqalculate but doesn't this lead to a mem leak?

Added a delete statement in the destructor to avoid possible leaks.


> On 2010-04-12 06:55:52, Alessandro Diaferia wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp, \
> > line 57 <http://reviewboard.kde.org/r/3483/diff/1/?file=22478#file22478line57>
> > 
> > wouldn't it be safer using QDir::homePath()? Or, better, does Qalculate have an \
> > access method for that directory?

Yes, I found a method in libqalculate and changed the code accordingly.


- Matteo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3483/#review4973
-----------------------------------------------------------


On 2010-04-14 12:47:15, Matteo Agostinelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3483/
> -----------------------------------------------------------
> 
> (Updated 2010-04-14 12:47:15)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> Adds libqalculate to the default calculator runner. This enables advanced features \
> such as unit/currency conversion, equation solving, symbolic manipulation and more. \
>  
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/cmake/modules/FindQalculate.cmake PRE-CREATION 
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/CMakeLists.txt \
>                 1109927 
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.h \
>                 1109927 
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/calculatorrunner.cpp \
>                 1109927 
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.h \
>                 PRE-CREATION 
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp \
> PRE-CREATION  
> Diff: http://reviewboard.kde.org/r/3483/diff
> 
> 
> Testing
> -------
> 
> Tested for several weeks without crashes
> 
> 
> Thanks,
> 
> Matteo
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]