[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Return 80% functionality to PMC,
From:       "Christophe Olinger" <olingerc () binarylooks ! com>
Date:       2010-04-14 13:52:37
Message-ID: 20100414135237.23527.4252 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
-----------------------------------------------------------

(Updated 2010-04-14 13:52:37.746381)


Review request for Plasma and Alessandro Diaferia.


Changes
-------

- I fixed the bug that caused some applets to disappear on resize
- I created 3 functions in playbackcontrol.h and controller.h that allow the states \
to give slider and playback button pointers to the controller. The connections \
between these widgets and the player are handled by the states. I could have done it \
the other way round (the controller gives pointers to the states) but this way is \
more consistent with the rest of the way the states work and also makes the layout of \
widgtes in the controller easier. I will have a closer look whether I can take \
further things out of the controller but I first wanted some feedback from this \
patch.

P.S. Transforming git diffs into reviewboard patches was not easy but I found a \
script that helped. Puuh 


Summary
-------

The state calsses now have less functions. Only one for connections and one for \
configuration. The first one is only called once at PMC initialization, the second \
one is called at each state switch. Some connections can conflict between states. \
Those are connected at entry() and disconnected at exit(). Thanks to Alessandr's work \
we can now also configure the layout from within the state class (I only had to \
correct some namespace stuff in the medialayout class, I hope that was correct). This \
patch also gets basic functionality back. The modes are not really useful yet. Video \
mode is the most complete and can be used to view everything at th moment. Next step: \
Clean this up a bit Think about subclassing plasma widgets to get the widget type \
into the widget. This is necessary to be able to tell the controller to layout into \
zones. Start work on information bar.


Diffs (updated)
-----

  trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp \
1113370   trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h \
1113370   trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp \
1113370 

Diff: http://reviewboard.kde.org/r/3552/diff


Testing
-------

Lots and lots. Seems to be quite slow, but I think that is a problem in the player. \
It always iterates over all the queue even if it should only show a picture.


Thanks,

Christophe

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]