[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Prefetching in Comic Strip plasmoid
From:       "Matthias Fuchs" <mat69 () gmx ! net>
Date:       2010-04-02 10:02:21
Message-ID: 20100402100221.10449.67604 () localhost
[Download RAW message or body]



> On 2010-04-01 21:33:03, Matthias Fuchs wrote:
> > Ok, I tried it now and it works great! Fantastic addition, really makes reading \
> > some comics more comfortable. Go on and commit it :) -- unless if you have no svn \
> > account then please write that here.
> 
> Miha Cancula wrote:
> Thank you :)
> And no, I don't have an account, so I have to ask that you or someone else do it.

Ok, comitted it, it is in r1110194, so that feature will be included with 4.5.


- Matthias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2636/#review4848
-----------------------------------------------------------


On 2010-01-25 10:19:38, Miha Cancula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2636/
> -----------------------------------------------------------
> 
> (Updated 2010-01-25 10:19:38)
> 
> 
> Review request for Plasma and Matthias Fuchs.
> 
> 
> Summary
> -------
> 
> When a new strip is loaded, it caches both the previous and the next one, without \
> interfering with the currently displayed comic. This is very useful if you're \
> reading throug a particular comic, especially on slower connections. It's a \
> two-line patch, but it greatly improves the experience for this use-case. Caching \
> is done by the DataEngine, so no further modifications were needed. 
> After a discussion in the mailing list, the decision was to have no configuration \
> for this, as the cost of downloading a single picture is qiute low. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 1075738 
> 
> Diff: http://reviewboard.kde.org/r/2636/diff
> 
> 
> Testing
> -------
> 
> I tested it on my Ubuntu machine with todays trunk. It works as expected, and I \
> haven't noticed any regressions. 
> 
> Thanks,
> 
> Miha
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]