From kde-panel-devel Wed Mar 31 17:14:38 2010 From: "Matthias Fuchs" Date: Wed, 31 Mar 2010 17:14:38 +0000 To: kde-panel-devel Subject: Re: Review Request: Prefetching in Comic Strip plasmoid Message-Id: <20100331171438.15502.30246 () localhost> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=127005570010150 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2636/#review4818 ----------------------------------------------------------- I am sorry it took so long for me to answer, I simply overlooked your review request. I haven't yet tried your patch, though it sounds very interesting -- depending on the comic I often had the same problem as well :) -- and I am going to try it the next days. - Matthias On 2010-01-25 10:19:38, Miha Cancula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2636/ > ----------------------------------------------------------- > > (Updated 2010-01-25 10:19:38) > > > Review request for Plasma and Matthias Fuchs. > > > Summary > ------- > > When a new strip is loaded, it caches both the previous and the next one, without interfering with the currently displayed comic. This is very useful if you're reading throug a particular comic, especially on slower connections. It's a two-line patch, but it greatly improves the experience for this use-case. Caching is done by the DataEngine, so no further modifications were needed. > > After a discussion in the mailing list, the decision was to have no configuration for this, as the cost of downloading a single picture is qiute low. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 1075738 > > Diff: http://reviewboard.kde.org/r/2636/diff > > > Testing > ------- > > I tested it on my Ubuntu machine with todays trunk. It works as expected, and I haven't noticed any regressions. > > > Thanks, > > Miha > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel