2010/3/29 Aaron Seigo : > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3417/#review4760 > ----------------------------------------------------------- > > > actually, don't bother committing this one as i've taken your patch and heavily modified it so that we now have a grid view for this. huzzah. > Nice work, thanks! Regards Darío A. > - Aaron > > > On 2010-03-28 16:36:48, Darío Andrés wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/3417/ >> ----------------------------------------------------------- >> >> (Updated 2010-03-28 16:36:48) >> >> >> Review request for Plasma. >> >> >> Summary >> ------- >> >> Update BackgroundDelegate to use QTextDocument in order to improve text layouting. >> Now, all the text is properly centered and long titles are wordwrapped correctly, maximizing the space usage. >> >> Compare http://bugsfiles.kde.org/attachment.cgi?id=42291 (from the bug report) and the attached screenshot >> >> I also cached some values to avoid a lot of calculations (useless as the ratio is not going to change) >> - Should some other values be cached too ? (the smallest font size?) >> >> >> This addresses bug 232348. >>     https://bugs.kde.org/show_bug.cgi?id=232348 >> >> >> Diffs >> ----- >> >>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/backgrounddelegate.h 1107102 >>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/backgrounddelegate.cpp 1107102 >> >> Diff: http://reviewboard.kde.org/r/3417/diff >> >> >> Testing >> ------- >> >> I have tested it and it works OK. >> There could be a minimal performance drop (as I guess that using QTextDocument takes more time than a few drawText() and QRect constructor calls); however I couldn't really notice it >> >> >> Screenshots >> ----------- >> >> Layouting improved >>   http://reviewboard.kde.org/r/3417/s/344/ >> >> >> Thanks, >> >> Darío >> >> > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel