[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Initial work on the flexible controller of the
From: "Christophe Olinger" <olingerc () binarylooks ! com>
Date: 2010-03-27 15:48:14
Message-ID: 20100327154814.10071.30812 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3396/
-----------------------------------------------------------
(Updated 2010-03-27 15:48:14.092413)
Review request for Plasma.
Changes
-------
Further work on handling mode switches concerning connections
I am not sure if I am on the right track here...
Eventualy when everything works, I'll reduce code duplication with some functions.
Summary
-------
This patch extends the controller applet by having 6 different layout modes which are \
adapted to what the media center is currently used for, i.e. browsing pictures, \
playing videos, etc. It sends a signal to the containment with the current mode. The \
containment then relayouts the other applets and configures them for the current \
Mode. These modes are defined as enum in the libs.
*The browser no longer has any controls. Those are now in the controller.
*The controller also has a show/hide playlist button and a toggle autohide button for \
itself.
*The different modes do not have sensible functions yet. I also need to work on \
configuring the applets for each mode, like telling the browser to hide, or the \
player to show.
*The controller is not really beautiful. I want animations for show(hide icons. I \
want the modeswitch button in a "drawer" perhaps. The toggle buttons need effects.
Diffs (updated)
-----
/trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.h \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.h \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.h \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.cpp \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/browser.cpp \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenter.h \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.h \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/playbackcontrol.cpp \
1108007 /trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp \
1108007
Diff: http://reviewboard.kde.org/r/3396/diff
Testing
-------
I tested the controller itself. The actual effect on the other applets when changing \
modes still needs work.
Thanks,
Christophe
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic