[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Initial work on the flexible controller of the
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-03-26 10:03:59
Message-ID: 20100326100359.7135.21097 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3396/#review4684
-----------------------------------------------------------
still can't comment on how it looks, i hope to have time to try it today.
in general i agree it should behave quite differently with diffrent type of medis, \
but i would also like being able to browse in a folder and being able to see anything \
it could contain, regardless if it's audio/video/pictures whatever, so it wouldn't be \
a type in particular..
also i feel that defining a set of "modes" this way it can be quite rigid. i can see \
in the future people wanting to write plugins to make it do radically different types \
of things. i would like for instance being able to browse launchers of applications \
to be able to have a "games" section for instance and i think it would be possible \
only by keeping things as more generic as possible.
when i'll have played a bit with it i will have clearer ideas perhaps. however i do \
think the general idea is correct, a rigid set of "modes" is a bit too much however
- Marco
On 2010-03-25 19:01:32, Christophe Olinger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3396/
> -----------------------------------------------------------
>
> (Updated 2010-03-25 19:01:32)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch extends the controller applet by having 6 different layout modes which \
> are adapted to what the media center is currently used for, i.e. browsing pictures, \
> playing videos, etc. It sends a signal to the containment with the current mode. \
> The containment then relayouts the other applets and configures them for the \
> current Mode. These modes are defined as enum in the libs.
> *The browser no longer has any controls. Those are now in the controller.
> *The controller also has a show/hide playlist button and a toggle autohide button \
> for itself.
> *The different modes do not have sensible functions yet. I also need to work on \
> configuring the applets for each mode, like telling the browser to hide, or the \
> player to show.
> *The controller is not really beautiful. I want animations for show(hide icons. I \
> want the modeswitch button in a "drawer" perhaps. The toggle buttons need effects.
>
> Diffs
> -----
>
> /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/abstractmediaitemview.cpp \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.h \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowser/mediabrowser.cpp \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.h \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.h \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/mediacontainment.cpp \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.h \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/containments/mediacontainment/medialayout.cpp \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/browser.cpp \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenter.h \
> 1107457
> /trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp \
> 1107457
> Diff: http://reviewboard.kde.org/r/3396/diff
>
>
> Testing
> -------
>
> I tested the controller itself. The actual effect on the other applets when \
> changing modes still needs work.
>
> Thanks,
>
> Christophe
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic