[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Fix taskmanager's "by desktop" sorting mode
From:       "Dmitry Suzdalev" <dimsuz () gmail ! com>
Date:       2010-03-23 20:48:15
Message-ID: 20100323204815.8045.1233 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3375/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch fixes a sorting order for "Sort by Desktop" mode of taskmanager lib.

Summary:
When in "Sort by Desktop" mode, sort by_desktop+by_winId, instead of \
by_desktop+by_winTitle as it is now.

More details:
Currently in "by desktop" sorting mode tasks are sorted by desktop and then by name.
This leads to inconvenient things, here are some examples:

- I have a browser with several tabs open. Whenever I change a tab, browser changes \
window title. This makes task jump in a task bar from one position to another while \
                I'm simply changing tabs.
- I have a 'konsole' window and as I do 'cd onedir', 'cd zletter_dir', etc, title is \
                changed, task jumps
- Some other situations caused this too, don't recall, but you got the idea :)

What I've done:
Instead of sorting by name, i made it to sort by winId. Tasks without winId are \
sorted out to the end of the list and sorted by name there. Typically these are the \
startup-in-progress items.

As a side effect this fixes bug https://bugs.kde.org/show_bug.cgi?id=219528 which has \
the same roots: invalid sorting order due to wrong comparison of regular items with \
"starting up" items.

Long description, short patch ;)


This addresses bug 219528.
    https://bugs.kde.org/show_bug.cgi?id=219528


Diffs
-----

  trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstrategy.cpp \
1105743 

Diff: http://reviewboard.kde.org/r/3375/diff


Testing
-------

Tested on trunk. Task items retain their sort order, not reacting to title changes, \
charming :)

It affects only task applets with sort mode set to "by desktop"


Thanks,

Dmitry

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]