[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Workaround in WebView...
From:       Marco Martin <notmart () gmail ! com>
Date:       2010-03-22 9:37:08
Message-ID: 201003221037.09012.notmart () gmail ! com
[Download RAW message or body]

On Monday 22 March 2010, Alexis Ménard wrote:
> Hello,
> 
> 
> May i know where was the crash? Because i'm sure the workaround is not
> needed anymore...
> 
> QVariant WebView::itemChange(GraphicsItemChange change, const QVariant
> &value) {
>     if (change == QGraphicsItem::ItemSceneHasChanged) {
>         //FIXME: QWebPage _requires_ a QWidget view to not crash in
> places such as
>         // WebCore::PopupMenu::show() due to
> hostWindow()->platformPageClient() == NULL
>         // because QWebPage::d->client is NULL
>         d->webView->page()->setView(viewFor(this));
>     }
>     return QGraphicsWidget::itemChange(change, value);
> }
> 
> Thank you....

iirc the crash was opening a combobox in a webpage.
right now this workaround causes many other crashes with a quite random 
behaviour, and one for which Amarok is being beaten quite a lot lately:
https://bugs.kde.org/show_bug.cgi?id=227639

Cheers,
Marco Martin
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread]