[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add "New Playlist" option to Media Center
From:       Alessandro Diaferia <alediaferia () gmail ! com>
Date:       2010-03-18 14:17:53
Message-ID: 65627f3a1003180717x9200716i211f2511d7fd598f () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


2010/3/18 Shantanu Tushar Jha <jhahoneyk@gmail.com>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3317/
> -----------------------------------------------------------
>
> Review request for Plasma, Marco Martin and Alessandro Diaferia.
>
>
> Summary
> -------
>
> This patch lets the user to add a new playlist to the Media Center playlist
> collection.
>
>
> Diffs
> -----
>
>  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.h
> 1104231
>  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.cpp
> 1104231
>  trunk/playground/base/plasma/MediaCenterComponents/dataengines/playlist/playlist.cpp
> 1104231
>
> Diff: http://reviewboard.kde.org/r/3317/diff
>
>
> Testing
> -------
>
> Adding new playlists work, so does adding media to the playlists. However,
> Media Player is only able to play media in one playlist. Input needed to
> resolve this - keep player's internal playlist in sync with the selected
> playlist, or tell the player when and what to play according to the playlist
> applet?
>
>
> Thanks,
>
> Shantanu
>
>
The patch looks good to me but i still have to try locally. The issue with
the player only seeing one playlist is just a bug. I probably forgot to look
for playlist changes. The MediaContainment is what you should look at. It
takes care of updating each applet internal state so you just have to
connect to the playlist and make it update the player internal queue
whenever the playlist changes. Hope it helps.

Regards

-- 
Alessandro Diaferia
KDE Developer
KDE e.V. member

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">2010/3/18 Shantanu Tushar Jha <span dir="ltr">&lt;<a \
href="mailto:jhahoneyk@gmail.com">jhahoneyk@gmail.com</a>&gt;</span><br><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> <br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/3317/" \
                target="_blank">http://reviewboard.kde.org/r/3317/</a><br>
-----------------------------------------------------------<br>
<br>
Review request for Plasma, Marco Martin and Alessandro Diaferia.<br>
<br>
<br>
Summary<br>
-------<br>
<br>
This patch lets the user to add a new playlist to the Media Center playlist \
collection.<br> <br>
<br>
Diffs<br>
-----<br>
<br>
   trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.h \
1104231<br>  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistwidget.cpp \
1104231<br>  trunk/playground/base/plasma/MediaCenterComponents/dataengines/playlist/playlist.cpp \
1104231<br> <br>
Diff: <a href="http://reviewboard.kde.org/r/3317/diff" \
target="_blank">http://reviewboard.kde.org/r/3317/diff</a><br> <br>
<br>
Testing<br>
-------<br>
<br>
Adding new playlists work, so does adding media to the playlists. However, Media \
Player is only able to play media in one playlist. Input needed to resolve this - \
keep player&#39;s internal playlist in sync with the selected playlist, or tell the \
player when and what to play according to the playlist applet?<br>

<br>
<br>
Thanks,<br>
<font color="#888888"><br>
Shantanu<br>
<br>
</font></blockquote></div><br>The patch looks good to me but i still have to try \
locally. The issue with the player only seeing one playlist is just a bug. I probably \
forgot to look for playlist changes. The MediaContainment is what you should look at. \
It takes care of updating each applet internal state so you just have to connect to \
the playlist and make it update the player internal queue whenever the playlist \
changes. Hope it helps.<br> <br>Regards<br clear="all"><br>-- <br>Alessandro \
Diaferia<br>KDE Developer<br>KDE e.V. member<br><br>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]