[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Improve Plasma::Dialog border checking,
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2010-03-16 20:41:02
Message-ID: 20100316204102.25883.61600 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3306/#review4525
-----------------------------------------------------------

Ship it!


looks good

- Marco


On 2010-03-16 20:40:35, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3306/
> -----------------------------------------------------------
> 
> (Updated 2010-03-16 20:40:35)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch splits themeUpdated() into a set of methods that do the border checking \
> and mask updating so that only the necessary work is actually done. The resize and \
> move events now also cooperate in the scheduling of calls to checkBorders (reducing \
> them by 50% or more during resizing). Calls to update(), which trigger full \
> repaints, are also minimized. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/plasma/dialog.h 1104111 
> /trunk/KDE/kdelibs/plasma/dialog.cpp 1104111 
> 
> Diff: http://reviewboard.kde.org/r/3306/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]