[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Shows QIcon inside plasmaengineexplorer when
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-03-15 22:57:45
Message-ID: 20100315225745.30789.86798 () localhost
[Download RAW message or body]



> On 2010-03-15 18:00:50, Aaron Seigo wrote:
> >
> 
> Matthieu Gallien wrote:
>     I do not have a SVN account. Can you commit it ?

sure :)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3283/#review4505
-----------------------------------------------------------


On 2010-03-14 18:25:13, Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3283/
> -----------------------------------------------------------
> 
> (Updated 2010-03-14 18:25:13)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Quick patch that adds a special case when the data inside the QVariant is convertible to a QIcon.
> Shows the QIcon instead of the text when the data is convertible to a QIcon.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.cpp 1103228 
> 
> Diff: http://reviewboard.kde.org/r/3283/diff
> 
> 
> Testing
> -------
> 
> Tested with both tasks data engine and the current version of the data engine for StatusNotifierItem.
> 
> 
> Thanks,
> 
> Matthieu
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]