[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: frame plasmoid: image load and scaling with
From:       "Davide Bettio" <davide.bettio () kdemail ! net>
Date:       2010-03-09 13:00:26
Message-ID: 20100309130026.16250.14606 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3162/
-----------------------------------------------------------

(Updated 2010-03-09 13:00:26.530767)


Review request for Plasma.


Changes
-------

Testing Done changed.


Summary
-------

First of all: **This is a preview of the patch** I'm still working on it but I need \
some advices. Picture Frame does 2 really bad things (when used with huge images):
* it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps
* plasma is blocked while the image is scaled
As side effect also X11 freezes.

This patch solves both issues using threads.

I think that we should remove "smooth scaling" option from our configuration UI. what \
do you think?


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.h PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.h PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 

Diff: http://reviewboard.kde.org/r/3162/diff


Testing (updated)
-------

I've been using the frame plasmoid with this patch and everything works correctly and \
X11 doesn't freeze anymore while scaling huge pictures. There was only one regression \
on the resize size which now it's "less realtime" than before but it can be fixed \
with another patch (I think that I can get it working better than before).


Thanks,

Davide

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]