----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4423 ----------------------------------------------------------- /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp connect below already /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp this is being connected below already /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp as far as i can see, the loader is never deleted. it emits its signal, pictureLoaded is called, and then the object is dropped and just sits there in memory. - Aaron On 2010-03-08 14:35:28, Davide Bettio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3162/ > ----------------------------------------------------------- > > (Updated 2010-03-08 14:35:28) > > > Review request for Plasma. > > > Summary > ------- > > First of all: **This is a preview of the patch** I'm still working on it but I need some advices. > Picture Frame does 2 really bad things (when used with huge images): > * it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps > * plasma is blocked while the image is scaled > As side effect also X11 freezes. > > This patch solves both issues using threads. > > I think that we should remove "smooth scaling" option from our configuration UI. what do you think? > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/appearanceSettings.ui 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.h 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 > /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 > > Diff: http://reviewboard.kde.org/r/3162/diff > > > Testing > ------- > > > Thanks, > > Davide > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel