From kde-panel-devel  Sat Mar 06 17:54:04 2010
From: "Davide Bettio" <davide.bettio () kdemail ! net>
Date: Sat, 06 Mar 2010 17:54:04 +0000
To: kde-panel-devel
Subject: Review Request: frame plasmoid: image load and scaling with threads
Message-Id: <20100306175404.5202.24300 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=126797771223726


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3162/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

First of all: **This is a preview of the patch** I'm still working on it but I need some advices.
Picture Frame does 2 really bad things (when used with huge images):
* it loads huge images (in my case 4000x3000 pixels) into X11 pixmaps
* plasma is blocked while the image is scaled
As side effect also X11 freezes.

This patch solves both issues using threads.

I think that we should remove "smooth scaling" option from our configuration UI. what do you think?


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/frame/CMakeLists.txt 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/imageloader.cpp PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/frame/imagescaler.cpp PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1093624 
  /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1093624 

Diff: http://reviewboard.kde.org/r/3162/diff


Testing
-------


Thanks,

Davide

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel