[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Manual panel hiding [WIP]
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-03-04 21:17:36
Message-ID: 20100304211736.27064.52631 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3121/#review4383
-----------------------------------------------------------


good start; looks fairly straightforward from here, i think.


/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp
<http://reviewboard.kde.org/r/3121/#comment3881>

    there is a ToolButton class which is a subclass of QToolButton but which provides \
plasma stylings. i wonder if that might look nicer here? just #include "toolbutton.h" \
and then do new ToolButton.  
    also, is it necessary to have a separate unhidebutton rather than just use the \
hide buttons themselves to both hide and unhide?  
    the hide button names are a but unfortunate as well; perhaps m_hideLeftTopButton \
and m_hideRightBottomButton? a bit more self documenting.



/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp
<http://reviewboard.kde.org/r/3121/#comment3880>

    instead of setting the margins on the containment, set the contents margins on \
the PanelView itself. then position the button inside of the PanelView itself. this \
is guaranteed not to break, regardless of what the containment tries to do.  
    i'd also position the buttons so they overlap the border of the svg. e.g. for the \
right-hand button in a horizontal panel, something like:   
    qreal left, top, right, bottom;
    containment()->getContentsMargins(&left, &top, &right, &bottom)
    setContentsMargins(0, 0, m_hideButton.width() - int(right), 0);
    m_hideButton->move(0, geometry().right() - m_hideButton.width());
    
    (obviously would need to be generalized for vertical panels and \
top/left/right/bottom buttons)


- Aaron


On 2010-03-04 19:19:53, Andrzej JR Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3121/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 19:19:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Manual panel hiding patch (still in progress). Currently only horizontal panels are \
> properly implemented, there is still a display bug whereby the plasma toolbox \
> (cashew) ignores the contentsMargins set on the containment and thus gets covered \
> by the hiding buttons. 
> 
> This addresses bug 158556.
> https://bugs.kde.org/show_bug.cgi?id=158556
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 
> 
> Diff: http://reviewboard.kde.org/r/3121/diff
> 
> 
> Testing
> -------
> 
> Hiding the panels, changing states, changing positions and sizes.
> 
> 
> Thanks,
> 
> Andrzej JR
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]