[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Additional style options for TaskManager e.g.
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-02-26 23:51:17
Message-ID: 20100226235117.20854.34918 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1342/#review4297
-----------------------------------------------------------

Ship it!



trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
<http://reviewboard.kde.org/r/1342/#comment3795>

    "em width" used to be the height of a capital 'M' in the typeface, leading to the \
phonetically spelled "em"; in any case, this just essentially sets the threshold to \
twice what it was. this can therefore probably just be fm.width('M') * 6. there is \
also QFontMetrics::averageCharWidth() but we probably want a maximal size rather than \
an average size and i'm concerned about the speed of that in such a hot path (looking \
at the code, it might be somewhat expensive ...)  
    this is also a value that could probably be cached, of course, and changed on \
font change .. but that's likely overengineering the whole thing.  
    in any case, 'M' * 6 is probably fine. please commit with that change :)


- Aaron


On 2010-02-25 15:53:26, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1342/
> -----------------------------------------------------------
> 
> (Updated 2010-02-25 15:53:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The attached diff adds three style options to the task manager widget.
> 
> In addition to the "normal" icon-and-text style you can now have a icon-only, 
> text-only or text-under-icon style.
> 
> This means that e.g. the tasks are displayed by icon only (a much bigger icon 
> though).
> 
> The additional styles are especially useful if you have a vertical panel. In 
> the icon-and-text style I only had five characters of the task name left.
> 
> The new styles can be selected in the "Task Manager Settings". Default is the 
> Windows like icon-and-text.
> 
> Heyho...
> Don't anyone want to review this?
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp \
> 1096015  
> Diff: http://reviewboard.kde.org/r/1342/diff
> 
> 
> Testing
> -------
> 
> Tried all possible combinations of style options.
> 
> Note: Manual grouping does not seem but work, but I couldn't get this to work with \
> the original either. 
> 
> Thanks,
> 
> Ralf
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]