[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Updated RSSNOW plasmoid animations to use
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2010-02-15 21:57:33
Message-ID: 20100215215733.27980.5551 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2924/#review4167
-----------------------------------------------------------

Ship it!


i think is good

- Marco


On 2010-02-15 02:56:29, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2924/
> -----------------------------------------------------------
> 
> (Updated 2010-02-15 02:56:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Replaced the deprecated animations API with QPropertyAnimation on RSSNOW plasmoid. \
> This could later be replaced by Plasma::Animator::SlideAnimation. The timer for \
> moveNext() or movePrevious() when the next or previous button is clicked got a \
> little delay (50ms) to avoid synchronization issues. Also, the animation easing \
> curve was changed from linear to InOutQuad, which gives a better look'n'feel :) 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeplasma-addons/applets/rssnow/scroller.h 1090250 
> trunk/KDE/kdeplasma-addons/applets/rssnow/scroller.cpp 1090250 
> 
> Diff: http://reviewboard.kde.org/r/2924/diff
> 
> 
> Testing
> -------
> 
> After compile + install, the RSS feed previous/next behaved the same as before, but \
> with some modifications (described above). 
> 
> Thanks,
> 
> Bruno
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]