From kde-panel-devel  Fri Jan 29 20:29:36 2010
From: "Aaron Seigo" <aseigo () kde ! org>
Date: Fri, 29 Jan 2010 20:29:36 +0000
To: kde-panel-devel
Subject: Re: Review Request: Fix segmentation fault at
Message-Id: <20100129202936.25468.15529 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=126479702607517


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2738/#review3973
-----------------------------------------------------------

Ship it!


:))

- Aaron


On 2010-01-29 20:25:39, loureiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2738/
> -----------------------------------------------------------
> 
> (Updated 2010-01-29 20:25:39)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> This is a small patch that fix a segmentation fault at plasma_applet_animation_example when we close the window.
> Basically I remove the delete sentence at the RotationStackedAnimation's destruct, I made it because I think when we create a QGraphicsLinearLayout passing a widget that widget will be the owner and responsible to delete it as well its children elements and running the example under valgrind I don't get leaks.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1082139 
>   trunk/KDE/kdelibs/plasma/animations/rotationstacked_p.h 1082139 
>   trunk/KDE/kdelibs/plasma/animations/stackedlayout.h 1082139 
>   trunk/KDE/kdelibs/plasma/animations/stackedlayout.cpp 1082139 
> 
> Diff: http://reviewboard.kde.org/r/2738/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> loureiro
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel