[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix segmentation fault at
From:       loureiro.andrew () gmail ! com
Date:       2010-01-29 19:32:53
Message-ID: 20100129193253.23940.83281 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2738/
-----------------------------------------------------------

(Updated 2010-01-29 19:32:53.244002)


Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson \
Cavalcanti.


Changes
-------

I updated the diff now I made the changes suggest by aseigo.


Summary
-------

This is a small patch that fix a segmentation fault at \
plasma_applet_animation_example when we close the window. Basically I remove the \
delete sentence at the RotationStackedAnimation's destruct, I made it because I think \
when we create a QGraphicsLinearLayout passing a widget that widget will be the owner \
and responsible to delete it as well its children elements and running the example \
under valgrind I don't get leaks.


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1082016 
  trunk/KDE/kdelibs/plasma/animations/rotationstacked_p.h 1082016 
  trunk/KDE/kdelibs/plasma/animations/stackedlayout.h 1082016 
  trunk/KDE/kdelibs/plasma/animations/stackedlayout.cpp 1082016 

Diff: http://reviewboard.kde.org/r/2738/diff


Testing
-------


Thanks,

loureiro

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]