[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix segmentation fault at
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-01-27 17:08:03
Message-ID: 20100127170803.17457.78876 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2738/#review3913
-----------------------------------------------------------


this will result in a leak when the layout isn't assigned. e.g.:

    Animation* rotStackedAnim = \
Plasma::Animator::create(Plasma::Animator::RotationStackedAnimation);  delete \
rotStackedAnim;

and then we have a leak.

what the dtor probably should be is:

if (!m_sLayout->parentLayoutItem()) {
     delete m_sLayout;
}

m_sLayout should also be a QWeakPointer since it could be deleted behind our backs.

- Aaron


On 2010-01-27 14:35:00, loureiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2738/
> -----------------------------------------------------------
> 
> (Updated 2010-01-27 14:35:00)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson \
> Cavalcanti. 
> 
> Summary
> -------
> 
> This is a small patch that fix a segmentation fault at \
> plasma_applet_animation_example when we close the window. Basically I remove the \
> delete sentence at the RotationStackedAnimation's destruct, I made it because I \
> think when we create a QGraphicsLinearLayout passing a widget that widget will be \
> the owner and responsible to delete it as well its children elements and running \
> the example under valgrind I don't get leaks. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/plasma/animations/rotationstacked.cpp 1080090 
> trunk/KDE/kdelibs/plasma/animations/stackedlayout.h 1080090 
> 
> Diff: http://reviewboard.kde.org/r/2738/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> loureiro
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]