From kde-panel-devel  Mon Jan 25 15:51:08 2010
From: "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date: Mon, 25 Jan 2010 15:51:08 +0000
To: kde-panel-devel
Subject: Re: Review Request: Add simple Type-and-Select feature to Folderview
Message-Id: <20100125155108.29892.26297 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=126443467125319


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2659/
-----------------------------------------------------------

(Updated 2010-01-25 15:51:08.463465)


Review request for Plasma, Fredrik Höglund and Celeste Lyn Paul.


Changes
-------

seele, your help is needed here to figure out what should be the expected behaviour for the type-and-select for folderview applet. The details have been discussed on the reviewboard page. Kindly take a look at the behaviour and what are your recommendations. Thanks :)


Summary
-------

This patch intends to provide a simple selection method to select icons. Its intended to be able to select a file plasma-desktop.desktop by just typing initial characters, "plas" for example.
Comments on the hard-coded 2000ms welcome. If the user doesn't press any key within 2000ms after the last key press, the match string clears.


This addresses bug 187241.
    https://bugs.kde.org/show_bug.cgi?id=187241


Diffs
-----

  trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1078728 
  trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1078728 

Diff: http://reviewboard.kde.org/r/2659/diff


Testing
-------

Works with the latest trunk.


Thanks,

Shantanu

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel