[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: clarification on bug 223684, proposed patch
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-01-21 21:10:46
Message-ID: 201001211310.47241.aseigo () kde ! org
[Download RAW message or body]

On January 21, 2010, Riccardo Iaconelli wrote:
> hello!
> I have been reported this bug
> https://bugs.kde.org/show_bug.cgi?id=223684 yesterday, via private
> mail, and I asked the guy to open a bug in bugzilla.
> you can read the description there, it looks like a really simple
> problem with the string returned by prettyTimezone().
> however, I am not sure if this was just a forgotten bug or the
> behiavour is actually intended, for some reason that i don't know.
> my patch to correct this is attached, do I have green light to commit?

i can't see your proposed patch anywhere there, but it seems the obvious 
answer is to take tzParts.value(tzParts.count() - 1) in setPrettyTimezone. if 
you agree, please feel free to commit away (and backport if you can :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]