[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add support for Opera Bookmarks in the Bookmarks
From:       klebezettel () gmx ! net
Date:       2010-01-15 19:52:21
Message-ID: 20100115195221.20961.20653 () localhost
[Download RAW message or body]



> On 2010-01-10 18:39:48, Marco Martin wrote:
> > to me more things supported the better.
> > plus opera bookmarks are quite simple so it doesn't add too much burden

Do you mind if I'm going to refactor the code a bit as a next patch? It's a little \
bit messy with all the switch statements. Instead, every browser specific part could \
be moved into a new class, and the main class could delegates to one of them.


- klebezettel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2539/#review3637
-----------------------------------------------------------


On 2010-01-10 16:14:55, klebezettel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2539/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 16:14:55)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This adds support for Opera Bookmarks in the bookmarks runner.
> 
> Basically it just reads ~/.opera/bookmarks.adr on a prepare() signal and searches \
> for something matching if match() is called. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp \
> 1072641  trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.h \
> 1072641  
> Diff: http://reviewboard.kde.org/r/2539/diff
> 
> 
> Testing
> -------
> 
> Test with my opera bookmarks.
> 
> 
> Thanks,
> 
> klebezettel
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]