[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Show the currently selected sensor in bubblemon
From:       "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date:       2010-01-02 18:26:23
Message-ID: 20100102182623.13145.46025 () localhost
[Download RAW message or body]



> On 2010-01-02 18:04:46, Shantanu Tushar Jha wrote:
> > Ok, seems to be good. Can be committed after feature freeze is over.
> 
> Beat Wolf wrote:
> i would say that this is a bugfix and can be committed now, hopefully before rc1 is \
> tagged

Committed revision 1069074. Close the review as submitted.


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2464/#review3558
-----------------------------------------------------------


On 2009-12-30 16:24:41, sudhendu kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2464/
> -----------------------------------------------------------
> 
> (Updated 2009-12-30 16:24:41)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The patch shows the currently selected sensor in bubblemon applet settings dialog.
> Previously it was difficult for the user to make out which sensor was selected.The \
> patch scrolls to the currently selected sensor. Hope this is fine, it's my first \
> patch. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeplasma-addons/applets/bubblemon/src/bubble.cpp 1067555 
> 
> Diff: http://reviewboard.kde.org/r/2464/diff
> 
> 
> Testing
> -------
> 
> Tested on trunk.The patch works correctly.
> 
> 
> Thanks,
> 
> sudhendu
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]