[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Make the Add Widgets context menu option work for
From:       "Shantanu Tushar Jha" <jhahoneyk () gmail ! com>
Date:       2009-12-31 19:26:57
Message-ID: 20091231192657.8975.45789 () localhost
[Download RAW message or body]



> On 2009-12-31 18:30:44, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp, lines 1060-1062
> > <http://reviewboard.kde.org/r/2467/diff/1/?file=16300#file16300line1060>
> > 
> > probably all that's needed to make this work better is to alter \
> > PlasmaApp::showWidgetExplorer so that it sets the location of the \
> > ControllerWindow based on the containment. so this in \
> > PlasmaApp::showWidgetExplorer: 
> > controller->setLocation(Plasma::BottomEdge)
> > 
> > becomes:
> > 
> > controller->setLocation(c->location());
> > 
> > and it should Just Work(tm) from there, as the default in \
> > ControllerWindow::setLocation is BottomEdge (so a Floating, Desktop or FullScreen \
> > location will behave as it currently does, which is what we need/want for the \
> > desktop views). 
> > i've just committed that change to svn, so you can go ahead and commit this \
> > patch. cheers :)

I updated from svn and recompiled, and here's what happened -

1. For a panel which is at the top, the Add Applet is still shown at the bottom.
2. For a vertical panel, the result is weird (see the new screenshot).

Any idea whats wrong?


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2467/#review3541
-----------------------------------------------------------


On 2009-12-31 04:28:54, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2467/
> -----------------------------------------------------------
> 
> (Updated 2009-12-31 04:28:54)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Problem- As of now, if the Add Widgets option in the Panel context menu is clicked, \
> nothing happens. Reason - The signal is connected to PanelController, which is only \
> shown when the panel toolbox is open. This solution - Make the PanelView class \
> handle the signal if the toolbox is not open. 
> A small problem - As I've used the method which is called for the Add Widgets \
> action in DesktopView, the problem with this is that the Widgets explorer is shown \
> at the bottom regardless of which panel the context menu belongs to (see the \
> screenshot). It is workable, but obviously doesn't feel good. One solution is to \
> make PanelView show the PanelController (toolbox) if the Add Widgets menu item was \
> selected and then call a public function in PanelController to show the Widgets \
> Explorer. Is it acceptable? If not, any suggestions? 
> 
> This addresses bug 217034.
> https://bugs.kde.org/show_bug.cgi?id=217034
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1067646 
> trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1067646 
> 
> Diff: http://reviewboard.kde.org/r/2467/diff
> 
> 
> Testing
> -------
> 
> Works on trunk build, except the minor issue as described above.
> 
> 
> Screenshots
> -----------
> 
> Add Widget clicked on upper panel
> http://reviewboard.kde.org/r/2467/s/284/
> After updating fromSVN
> http://reviewboard.kde.org/r/2467/s/285/
> 
> 
> Thanks,
> 
> Shantanu
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]