From kde-panel-devel  Sat Dec 19 17:50:20 2009
From: "Bruno Abinader" <brunoabinader () gmail ! com>
Date: Sat, 19 Dec 2009 17:50:20 +0000
To: kde-panel-devel
Subject: Re: Review Request: Added "scrollingState" property to
Message-Id: <20091219175020.25154.81591 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=126124503915352


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2391/
-----------------------------------------------------------

(Updated 2009-12-19 17:50:20.277266)


Review request for Plasma and Marco Martin.


Changes
-------

Updated patch according to review made by mart: Plasma::Animator::scrollState() goes private and is seen only by Plasma::ScrollWidget (friend class). Also I've renamed all scrollingState() methods to scrollState(), as it looks more sexy :) 


Summary
-------

This patch adds the "scrollingState" read-only property to Plasma::ScrollWidget. This is sometimes necessary when you need to know the scrolling animation state before or after executing another piece of code (eg: another animation).


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1063898 
  trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1063898 
  trunk/KDE/kdelibs/plasma/animator.h 1063898 
  trunk/KDE/kdelibs/plasma/deprecated/animator.cpp 1063898 
  trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1063898 
  trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1063898 

Diff: http://reviewboard.kde.org/r/2391/diff


Testing
-------

Using a test plasmoid [1], after this patch it was able to do the following call:

if (m_scrollWidget->scrollingState() == QAbstractAnimation::Stopped) {
    doSomething();
}

[1] http://gitorious.org/contact-list-plasmoid-example/contact-list-plasmoid-example/commit/09fc6b8781d4d52a32f2f2e5c96fa2c6e904a8ea

Notice that the other plasmoids won't be affected by this patch, since it only adds a new method, not altering or removing the existent behaviour.


Thanks,

Bruno

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel