[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Added "scrollingState" property to
From:       "Bruno Abinader" <brunoabinader () gmail ! com>
Date:       2009-12-16 22:22:51
Message-ID: 20091216222251.31994.43344 () localhost
[Download RAW message or body]



> On 2009-12-16 21:18:13, Marco Martin wrote:
> > trunk/KDE/kdelibs/plasma/animator.h, line 208
> > <http://reviewboard.kde.org/r/2391/diff/1/?file=15635#file15635line208>
> > 
> > i think it should be private, with kineticscroll as friend of animator.
> > it not big point to have it in public api

Indeed, this method only makes sense if the plasma widget uses the scrolling manager. \
But, I think that the correct chain of thought is to put the classes that are going \
to call for this method to be friends of Plasma::Animator, not the KineticScroll \
class, right?


- Bruno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2391/#review3439
-----------------------------------------------------------


On 2009-12-16 21:10:35, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2391/
> -----------------------------------------------------------
> 
> (Updated 2009-12-16 21:10:35)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch adds the "scrollingState" read-only property to Plasma::ScrollWidget. \
> This is sometimes necessary when you need to know the scrolling animation state \
> before or after executing another piece of code (eg: another animation). 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/plasma/animator.h 1063001 
> trunk/KDE/kdelibs/plasma/deprecated/animator.cpp 1063001 
> trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1063001 
> trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1063001 
> trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1063001 
> trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1063001 
> 
> Diff: http://reviewboard.kde.org/r/2391/diff
> 
> 
> Testing
> -------
> 
> Using a test plasmoid [1], after this patch it was able to do the following call:
> 
> if (m_scrollWidget->scrollingState() == QAbstractAnimation::Stopped) {
> doSomething();
> }
> 
> [1] http://gitorious.org/contact-list-plasmoid-example/contact-list-plasmoid-example/commit/09fc6b8781d4d52a32f2f2e5c96fa2c6e904a8ea
>  
> Notice that the other plasmoids won't be affected by this patch, since it only adds \
> a new method, not altering or removing the existent behaviour. 
> 
> Thanks,
> 
> Bruno
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]