From kde-panel-devel Wed Nov 25 00:44:10 2009 From: "Chani Armitage" Date: Wed, 25 Nov 2009 00:44:10 +0000 To: kde-panel-devel Subject: Re: Review Request: popup ContextMenu at a sensible position Message-Id: <20091125004410.27742.17191 () localhost> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=125910989904659 > On 2009-11-25 00:18:30, Aaron Seigo wrote: > > this feels broken. i think klipper should just popup the menu where the mouse is (more clever schemes might entail finding what widget has focus ... but ... yeah, i don't think we need to get that fancy) it has an option for that already. it just doesn't explicitly say what happens when that opton isn't checked... - Chani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2278/#review3258 ----------------------------------------------------------- On 2009-11-24 23:24:07, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2278/ > ----------------------------------------------------------- > > (Updated 2009-11-24 23:24:07) > > > Review request for Plasma. > > > Summary > ------- > > unsure on this and is a bit late, even. > a roadblock for klipper porting to kstatusnotifieritem is that with a global shortcut it posps up the menu and is not possible to make it pop up at the "proper" systray... > > this adds a slot that calls ContextMenu on the systray nearest to the mouse upon a signal ContextMenuRequested() that would be emitted from the StatusNotifierItem... > > i think just popping up the menu at mouse cursor position would be nicer, more correct etc, but this could be a solution too... > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1053758 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1053758 > > Diff: http://reviewboard.kde.org/r/2278/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel