[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Make folderview's hovering popups more usable
From:       "Shafqat Bhuiyan" <priomsrb () gmail ! com>
Date:       2009-11-23 23:27:28
Message-ID: 20091123232728.16362.7364 () localhost
[Download RAW message or body]



> On 2009-11-23 22:15:16, Fredrik Höglund wrote:
> > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1669
> > <http://reviewboard.kde.org/r/2262/diff/1/?file=14932#file14932line1669>
> > 
> > Stopping the timer once should hopefully be enough (See the line below this one).

Whoops. I guess I should of svn up before I started :)


- Shafqat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2262/#review3246
-----------------------------------------------------------


On 2009-11-22 19:56:03, Shafqat Bhuiyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2262/
> -----------------------------------------------------------
> 
> (Updated 2009-11-22 19:56:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds two things to make the folderview hovering popups more usable:
> 1. Don't show popup after user clicks on a folder
> 2. Close all popups after user clicks on a file/folder
> 
> Part 1 should be good for all users. However part 2 make takes away multi-file \
> opening. I think this is the correct behavior because this is how most people are \
> accustomed to hovering popup views(eg classic application launchers). Also if a \
> user wants to open multiple files he/she can just open the folder with the files \
> inside. 
> This patch isn't too drastic so it may be backported
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1052895 
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.h 1052895 
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.cpp 1052895 
> 
> Diff: http://reviewboard.kde.org/r/2262/diff
> 
> 
> Testing
> -------
> 
> Tested in trunk
> 
> 
> Thanks,
> 
> Shafqat
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]