[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add support for single Runner queries to krunner
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-11-12 21:38:15
Message-ID: 20091112213815.13824.39198 () localhost
[Download RAW message or body]



> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406
> > <http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406>
> > 
> > this should probably be setDefaultSyntax, since it doesn't really add another \
> > default syntax. also prevents the need to explain how it works in the apidox :)
> 
> Jacopo De Simoi wrote:
> well, the correct name should indeed be
> addSyntaxAndSetAsDefault, but I guess it's a little bit too much :)

i think setDefaultSyntax implies it will become part of the syntax bunch; perhaps a \
note in the apidox that it isn't necessary to to also call addSyntax and a check to \
ensure it isn't already in the collection might be in order.


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > <http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149>
> > 
> > const bool isn't necessary; in fact, i think this whole method shouldn't be \
> > necessary at all. if RunnerContext::singleRunnerMode() then replaceEmptyQuery \
> > should be implied?
> 
> Jacopo De Simoi wrote:
> In fact it should. I was worried of changing the default behaviour of this method. \
> I was not sure to be able to check that this wouldn't affect any other app using \
> runnermanager (kickoff?)

i don't see how it could affect any other users; if they don't call \
setSingleRunnerMode(true) it behaves exactly as it did before. so it would require \
purposefully changing the code in the other places it is used to cause problems :)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
-----------------------------------------------------------


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> -----------------------------------------------------------
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> -------
> 
> This is the API needed by the new single Runner mode for krunner (more on usecases \
> in part II:krunner) for kdelibs; 
> A runner can now optionally define a Default syntax; if this is the case, the \
> runner will be exposed as single-runner-mode capable.  On request, the default \
> syntax will be replaced to the empty query in RunnerManager::launchQuery. 
> The context is aware of the fact that we are in single runner query mode in case \
> the runners need to change their behaviour accordingly (e.g. to _not_ discard \
> queries with less than 3 chars) 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
> trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
> trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
> trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
> trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
> trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]