[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Embed related kcms in the device notifier
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-11-02 18:20:12
Message-ID: 20091102182012.27860.42667 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1979/#review2894
-----------------------------------------------------------

Ship it!


"what is the situation with the device-automounter? I could only find a copy in \
kdereview"

yes, it's in review. that means it's on track for 4.4

"* If you think it's worth to add such options, please help with the naming.. I've no \
good ideas today ;) "

i think it's good as is?

"* Is there a template for non-trivial plasmoid config uis?   "

no; probably something we should add at some point ;)

- Aaron


On 2009-10-31 10:40:50, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1979/
> -----------------------------------------------------------
> 
> (Updated 2009-10-31 10:40:50)
> 
> 
> Review request for Plasma, Aaron Seigo, Trever Fischer, Kevin Ottens, and Ben \
> Cooksley. 
> 
> Summary
> -------
> 
> This patch adds to the configuration interface two buttons which links to two \
> related kcms;  
> (btw, what is the situation with the device-automounter? I could only find a copy \
> in kdereview) 
> * If you think it's worth to add such options, please help with the naming.. I've \
>                 no good ideas today ;) 
> * Is there a template for non-trivial plasmoid config uis?   
> 
> 
> This addresses bugs 187054 and 194894.
> https://bugs.kde.org/show_bug.cgi?id=187054
> https://bugs.kde.org/show_bug.cgi?id=194894
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/CMakeLists.txt \
> 1040042  trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.cpp \
> 1040042  
> Diff: http://reviewboard.kde.org/r/1979/diff
> 
> 
> Testing
> -------
> 
> It works as expected
> 
> 
> Screenshots
> -----------
> 
> new config window [2]
> http://reviewboard.kde.org/r/1979/s/243/
> 
> 
> Thanks,
> 
> Jacopo
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]