From kde-panel-devel  Sat Oct 31 10:40:58 2009
From: "Jacopo De Simoi" <wilderkde () gmail ! com>
Date: Sat, 31 Oct 2009 10:40:58 +0000
To: kde-panel-devel
Subject: Re: Review Request: Embed related kcms in the device notifier
Message-Id: <20091031104058.11964.79012 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=125698756502560


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1979/
-----------------------------------------------------------

(Updated 2009-10-31 10:40:50.365695)


Review request for Plasma, Aaron Seigo, Trever Fischer, Kevin Ottens, and Ben Cooksley.


Changes
-------

Now the kcms are embedded in the notifier configuration dialog; slickness++


Summary (updated)
-------

This patch adds to the configuration interface two buttons which links to two related kcms; 

(btw, what is the situation with the device-automounter? I could only find a copy in kdereview)

* If you think it's worth to add such options, please help with the naming.. I've no good ideas today ;) 
* Is there a template for non-trivial plasmoid config uis?   


This addresses bugs 187054 and 194894.
    https://bugs.kde.org/show_bug.cgi?id=187054
    https://bugs.kde.org/show_bug.cgi?id=194894


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/CMakeLists.txt 1040042 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.cpp 1040042 

Diff: http://reviewboard.kde.org/r/1979/diff


Testing
-------

It works as expected


Screenshots (updated)
-----------

new config window [2]
  http://reviewboard.kde.org/r/1979/s/243/


Thanks,

Jacopo

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel