[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma Netbook animated Version 1
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2009-10-30 11:57:24
Message-ID: 20091030115724.17745.67863 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2008/#review2870
-----------------------------------------------------------

Ship it!


to me looks good.
i think the grid animation there is here should be seen only when slow runners add \
icons to an already completed result set, probably the first population should be \
done with a slide animation of the whole mainwidget rather than individual icons \
should be a bit faster and and look less busy. but i think that's for post-commit

- Marco


On 2009-10-30 03:40:42, igorto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2008/
> -----------------------------------------------------------
> 
> (Updated 2009-10-30 03:40:42)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz), \
> and Adenilson Cavalcanti. 
> 
> Summary
> -------
> 
> Add animated layouts to plasma-netbook.
> Animate add/remove widgets in layouts(grid and linear).
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt \
> 1042281  trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h \
> 1042281  trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp \
> 1042281  trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h \
> 1042281  trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp \
> 1042281  trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt \
> 1042281  trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h \
> 1042281  trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp \
> 1042281  
> Diff: http://reviewboard.kde.org/r/2008/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> igorto
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]