[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add to the devicenotifier configuration buttons
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-10-27 16:16:58
Message-ID: 20091027161658.30395.1668 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1979/#review2832
-----------------------------------------------------------


instead of launching kcmshell, you should be able to just KRun::run the service which \
can be retrieved by name. however, i wonder if it wouldn't make more sense to show \
the configuration pages right inside the plasmoid config dialog? this should be \
possible by using KCModuleProxy and then adding that as a page to the dialog.

another approach might be to run systemsettings and have it start with the \
appropriate model, helping the user learn where to find these next time. but i do \
think that integrating the pages right into the device notifier dialog with \
KCModuleProxy would be the slickest.

- Aaron


On 2009-10-26 18:33:26, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1979/
> -----------------------------------------------------------
> 
> (Updated 2009-10-26 18:33:26)
> 
> 
> Review request for Plasma, Aaron Seigo, Trever Fischer, and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds to the configuration interface two buttons which links to two \
> related kcms;  
> (btw, what is the situation with the device-automounter? I could only find a copy \
> in kdereview) 
> * If you think it's worth to add such options, please help with the naming.. I've \
>                 no good ideas today ;) 
> * Is there a template for non-trivial plasmoid config uis?   
> 
> 
> This addresses bugs 187054 and 194894.
> https://bugs.kde.org/show_bug.cgi?id=187054
> https://bugs.kde.org/show_bug.cgi?id=194894
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/configurationpage.ui \
> 1040042  trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.h \
> 1040042  trunk/KDE/kdebase/workspace/plasma/generic/applets/devicenotifier/devicenotifier.cpp \
> 1040042  
> Diff: http://reviewboard.kde.org/r/1979/diff
> 
> 
> Testing
> -------
> 
> It works as expected
> 
> 
> Screenshots
> -----------
> 
> new config window
> http://reviewboard.kde.org/r/1979/s/239/
> 
> 
> Thanks,
> 
> Jacopo
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]