From kde-panel-devel  Mon Oct 26 16:32:22 2009
From: "Pino Toscano" <pino () kde ! org>
Date: Mon, 26 Oct 2009 16:32:22 +0000
To: kde-panel-devel
Subject: Re: Review Request: support for latex colours in kolorpicker.
Message-Id: <20091026163222.28799.19133 () localhost>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=125657483517714


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1747/#review2812
-----------------------------------------------------------



/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp
<http://reviewboard.kde.org/r/1747/#comment2186>

    Use the KLocale function to remove the accelerators. (Yes, the current code does that, but when I wrote it KLocale didn't have it, so while you are there you can apply it.)



/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp
<http://reviewboard.kde.org/r/1747/#comment2185>

    Bracket goes in own line (same for following lines).


- Pino


On 2009-09-30 17:30:08, Tomaz Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1747/
> -----------------------------------------------------------
> 
> (Updated 2009-09-30 17:30:08)
> 
> 
> Review request for Plasma and Pino Toscano.
> 
> 
> Summary
> -------
> 
> adds support for latex color on kolourpicker menu.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp 1029750 
> 
> Diff: http://reviewboard.kde.org/r/1747/diff
> 
> 
> Testing
> -------
> 
> works, no drawbacks or regressions found.
> 
> 
> Thanks,
> 
> Tomaz
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel