[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Move activation of Present Windows effect to
From:       "Artur de Souza \(MoRpHeUz\)" <asouza () kde ! org>
Date:       2009-10-15 10:43:49
Message-ID: 20091015104349.11078.92550 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1852/#review2654
-----------------------------------------------------------

Ship it!


Besides from the comment below it seems great. We really wanted this for a long time \
now... :)


trunk/KDE/kdelibs/plasma/windoweffects.cpp
<http://reviewboard.kde.org/r/1852/#comment1978>

    Shouldn't be if (!data.isEmpty()) ?


- Artur


On 2009-10-15 09:03:41, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1852/
> -----------------------------------------------------------
> 
> (Updated 2009-10-15 09:03:41)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Added two methods to WindowsEffects to activate the Present Windows effect either \
> for windows on a desktops or for a group of windows and replaced it in the \
> currentappcontrol and tasks applets. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1030597 
> trunk/KDE/kdebase/workspace/plasma/netbook/applets/currentappcontrol/currentappcontrol.cpp \
> 1030597  trunk/KDE/kdelibs/plasma/windoweffects.h 1034782 
> trunk/KDE/kdelibs/plasma/windoweffects.cpp 1034782 
> 
> Diff: http://reviewboard.kde.org/r/1852/diff
> 
> 
> Testing
> -------
> 
> Currentappcontrol is still working. The activation for grouped tasks does not work \
> (and didn't before) or I don't know how to trigger it ;-) 
> 
> Thanks,
> 
> Martin
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]