[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix several kdelibs/plasma issues reported by
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2009-10-13 9:16:24
Message-ID: 20091013091624.9393.25797 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1837/#review2626
-----------------------------------------------------------

Ship it!


yeah, minor nitpickings that i like seeing fixed, good job :)

- Marco


On 2009-10-12 23:29:49, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1837/
> -----------------------------------------------------------
> 
> (Updated 2009-10-12 23:29:49)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> A bunch of small fixes reported by Krazy2 and by the compiler. I'm posting this \
> here to not break kdelibs without permission :) There are still some things to fix \
> QtWidgets->KDEWidgets and some i18n and spelling errors in APIDOX. 
> 
> Diffs
> -----
> 
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/containmentactions.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/context.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/framesvg.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/popupapplet.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/nativetabbar.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/private/wallpaperrenderthread.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/runnersyntax.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/checkbox.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/frame.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/itembackground.h \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/label.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/pushbutton.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/radiobutton.cpp \
> 1034418  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/plasma/widgets/toolbutton.cpp \
> 1034418  
> Diff: http://reviewboard.kde.org/r/1837/diff
> 
> 
> Testing
> -------
> 
> The code compiles. The changes should not affect the code behavior.
> 
> 
> Thanks,
> 
> Darío
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]