From kde-panel-devel  Wed Sep 30 17:29:29 2009
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Wed, 30 Sep 2009 17:29:29 +0000
To: kde-panel-devel
Subject: Re: Qalculate plasmoid in kdeplasma-addons
Message-Id: <200909301129.30565.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=125433189720291
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1759390763=="

--===============1759390763==
Content-Type: multipart/signed;
  boundary="nextPart1385927.akJKn1U2Sa";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1385927.akJKn1U2Sa
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On September 30, 2009, Matteo Agostinelli wrote:
> Also, I would like to add that this is not meant to be a replacement of t=
he
> existing calculator but an optional "enhanced" calculator, since it
>  requires an additional external dependency (libqalculate). So IMO the
>  current choice of branding (name and icon) could be acceptable. If there

so i finally got it built and found some time to test it. some input:

* it uses QHttp; it must use KIO instead

* the network access in QalculateEngine::updateExchangeRates() is blocking=
=20
rather than async

* there's nothing that defines the widget as being a calculator when it's j=
ust=20
sitting there. perhaps when there are no results the qalculate icon could b=
e=20
painted in the results area? or even the icon and the name? probably don't=
=20
want to do anything with the line edit as it should have as much space as=20
possible

* minor issue: there's a tooltip even when the widget is shown fully on the=
=20
desktop that probably isn't overly useful

>  are no objections, I would like to move it to kdeplasma-addons next
>  weekend. I am willing to mantain it in the future.

i'm cool with this; the code looks good and if you are willing / able to=20
maintain it -> win! :) i look forward to seeing this in plasma-addons for 4=
=2E4.=20
do you have a checkout of kdebase around? if you do, could you put an entry=
 in=20
workspace/plasma/design/CHANGELOG-4.4 for this? (if not, i can do it for yo=
u)

btw, is libqalculate thread safe? if so, would you be interested in hooking=
 up=20
qalculate to the calculator runner? if qalculate doesn't exist, it could fa=
ll=20
back to the current "evaluate it using qscript" method, but if qalculate do=
es=20
exist it could get us a much nicer calculator runner.

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

--nextPart1385927.akJKn1U2Sa
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkrDlXoACgkQ1rcusafx20OyGACgjsOR4YLLeWbSDzDXnvl6J5qz
AsYAn3no7gtChZothmoAdf9d7bRD1kVR
=OvfW
-----END PGP SIGNATURE-----

--nextPart1385927.akJKn1U2Sa--

--===============1759390763==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1759390763==--