--===============0787678496==
Content-Type: multipart/signed;
  boundary="nextPart15498139.FHkWoS6Xkh";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart15498139.FHkWoS6Xkh
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi Jon,

On Tuesday 29 September 2009 00:15:34 Jon de Andres wrote:
> The browserhistory runner in kdeplasma-addons only searchs in the typed
>  history in konqueror, stored in KDEDIR/share/conf/konq_history. Konqueror
>  uses its own lib to use the "full" history with title and extra info. Th=
is
>  runner do use the KonqHistoryProvider to search in this history, stored =
in
>  KDEDIR/share/apps/konqueror/konq_history.

I've talked with dfaure about that about a year ago, he seemed positive tow=
ards=20
making this history part of the lib public API. You need to talk to him tho=
ugh to get=20
it done.

> Probably this runner is used with the rekonq browser but we think that it
>  could be useful for KDE users so it searches in the title and url as we
>  can see in other browsers, firefox, chromium, etc...
>=20
> In kdebase/apps/lib/konq lives the lib used by konqueror and this runner,
>  in this folder there are some headers, konq_history*.h that are needed to
>  be installed. So the CMakeLists.txt should be fixed.

Also, the runner should completely replace the browserhistory runner, both =
in our=20
sources but also its pluginnames. There shouldn't be two runners, and users=
 who have=20
configured the "old" one, should get the new one automatically.

In the code, you have this TODO to connect signals to update. That's actual=
ly a=20
pretty important thing (the history changes much more often than you restar=
t=20
KRunner). So with this added, and David having made the necessary changes t=
o libkonq,=20
it can go in.

You can test your runner by only enabling that one, and then see if you sti=
ll get=20
crashes. Maybe konqhistory isn't thread-safe?

The code looks good to me, otherwise.=20

Welcome to Plasma development, btw :)
=2D-=20
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

--nextPart15498139.FHkWoS6Xkh
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQEcBAABAgAGBQJKwebjAAoJEGdNh9WRGQ75F0sIAL9cMCvMLa6hdGBlcnYsBEtu
1e6yslA578/x8NFjXuPWwHM2TOXCLPOUgtfR/Ujnze+lLU6JR9Pj8Q63gEt3Pozx
uRXaixiLoS43SwC7mFslkni1/zSX/LxVUkAJa7R74KsEsStyfVJC8/p4QsPJJfmo
BfjC3ji0UklfnQ+QVU8rbrSC1u4PctuIrfyW9fvW3FVAt27dO5yz/sXK251ECXRk
90RDMX1ucfb+lQeW0RYjFq0n2vMEzFt4BiuhkB08LTK4kmkxaZ6LCTrVMYTgxcd2
LUATVPB4q4x4X0sbKdSiYt+6ufW03+F0/PzaSViO2IDaQHU0qLCdCZOjLMf5ka8=
=j1Fq
-----END PGP SIGNATURE-----

--nextPart15498139.FHkWoS6Xkh--

--===============0787678496==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============0787678496==--