[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Ported KTimeTracker to KNotification
From:       "Beat Wolf" <asraniel () fryx ! ch>
Date:       2009-09-29 6:56:26
Message-ID: 20090929065626.4109.42854 () localhost
[Download RAW message or body]



> On 2009-09-29 05:32:23, Thorsten Staerk wrote:
> > I committed the change, see \
> > http://websvn.kde.org/?view=revision&revision=1029142. Where can I set this to \
> > completed?

there is somewhere a button here that lets you set this to submitted.


- Beat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1653/#review2495
-----------------------------------------------------------


On 2009-09-19 20:16:41, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated 2009-09-19 20:16:41)
> 
> 
> Review request for KDE PIM and Plasma.
> 
> 
> Summary
> -------
> 
> KTimeTracker has been ported to KNotificationItem but I still have few issues that \
> I've corrected with #if 0. It's not really clear to me how the notification works \
> when KTimeTracker is a KPart. Anyway please don't use XPM pixmaps, use icons.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122 
> /trunk/KDE/kdepim/ktimetracker/tray.h 1024122 
> /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122 
> 
> Diff: http://reviewboard.kde.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]