[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: contextmenu on popupapplets
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2009-09-29 3:04:25
Message-ID: 20090929030425.31612.87739 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1737/#review2494
-----------------------------------------------------------
yes, please make this private API, otherwise, it's good to go from my end...
- Aaron
On 2009-09-29 00:42:23, Chani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1737/
> -----------------------------------------------------------
>
> (Updated 2009-09-29 00:42:23)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> when I rightclick a popupapplet, I expect to get a contextmenu, but it doesn't happen because the event \
> reaches Plasma::Dialog and stops. with this code, popupapplet grabs the event and makes sure it gets \
> through. :) since everything is handled by Containment (there is no Applet::contextMenuEvent) I bypass \
> the usual checks (they'd just break things anyways since it's not a qgraphicssceneevent) with a new \
> function in Containment. I'm wondreing if I should make that new function protected or private, though, \
> and make popupapplet a friend.
> there are still some big dead areas on kickoff and device notifier that just eat clicks; maybe I'll fix \
> that too at some point.
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/containment.h 1027322
> /trunk/KDE/kdelibs/plasma/containment.cpp 1027322
> /trunk/KDE/kdelibs/plasma/popupapplet.cpp 1027322
>
> Diff: http://reviewboard.kde.org/r/1737/diff
>
>
> Testing
> -------
>
> works on panel and desktop.
>
>
> Thanks,
>
> Chani
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic