[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Full Konqueror History Runner
From:       "Jon de Andres" <jondeandres () gmail ! com>
Date:       2009-09-28 22:15:34
Message-ID: 20090928221534.25506.97541 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1719/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

The browserhistory runner in kdeplasma-addons only searchs in the typed history in \
konqueror, stored in KDEDIR/share/conf/konq_history. Konqueror uses its own lib to \
use the "full" history with title and extra info. This runner do use the \
KonqHistoryProvider to search in this history, stored in \
KDEDIR/share/apps/konqueror/konq_history.

Probably this runner is used with the rekonq browser but we think that it could be \
useful for KDE users so it searches in the title and url as we can see in other \
browsers, firefox, chromium, etc...

In kdebase/apps/lib/konq lives the lib used by konqueror and this runner, in this \
folder there are some headers, konq_history*.h that are needed to be installed. So \
the CMakeLists.txt should be fixed.


Diffs
-----

  /trunk/playground/base/plasma/runners/CMakeLists.txt 1029048 
  /trunk/playground/base/plasma/runners/konqhistory/CMakeLists.txt PRE-CREATION 
  /trunk/playground/base/plasma/runners/konqhistory/konqhistory.h PRE-CREATION 
  /trunk/playground/base/plasma/runners/konqhistory/konqhistory.cpp PRE-CREATION 
  /trunk/playground/base/plasma/runners/konqhistory/plasma-konqhistoryrunner.desktop \
PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1719/diff


Testing
-------

I've noticed that krunner crashes sometimes, however i don't know if it's really a \
problem with this runner.


Thanks,

Jon

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]