[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: taskmanager library: Manual Sorting Fix
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2009-09-28 20:26:09
Message-ID: 20090928202609.22390.23270 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1526/
-----------------------------------------------------------

(Updated 2009-09-28 20:26:09.228700)


Review request for Plasma, Aaron Seigo and Marco Martin.


Summary
-------

this fixes the manual sorting strategy, which is broken atm if the desktop is \
changed.

Since the manual sorting strategy relies on AbstractGroupableItem pointer not to \
change, we cannot remove it from the bookkeeping in case it returns (after a desktop \
change for instance). I don't know if this is acceptable because this results in the \
item never being removed from the itemList until the groupmanager instance is deleted \
(lifetime of the applet which created the instance).

Another option would be to identify tasks and groups by WId, which is a bit more \
complicated, but if you think it would be better/cleaner, i could supply a patch.


This addresses bug 200255.
    https://bugs.kde.org/show_bug.cgi?id=200255


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1018615 

Diff: http://reviewboard.kde.org/r/1526/diff


Testing
-------

Tried it, works.


Thanks,

Christian

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]