[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Center tool tips in Plasma
From:       "Michal Dutkiewicz" <emdeck () gmail ! com>
Date:       2009-09-27 13:18:54
Message-ID: 20090927131854.30514.68181 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1428/
-----------------------------------------------------------

(Updated 2009-09-27 13:18:54.556459)


Review request for Plasma and Aaron Seigo.


Changes
-------

Replaced bool parameter by alignment flag, added new public methods, for Corona and \
Applet. Accepted alignment flags are Qt::AlignLeft (default, for compatibility), \
Qt::AlignCenter and Qt::AlignRight. Additionally it tries to reverse alignment (if \
different than center) for RTL languages.


Summary (updated)
-------

This patch aims to provide centered tool tips for Plasma (aligned to edge in some \
cases looks bad) and ability to set pop ups alignment (by default it uses left \
alignment for compatibility).


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/applet.h 1028190 
  /trunk/KDE/kdelibs/plasma/applet.cpp 1028190 
  /trunk/KDE/kdelibs/plasma/corona.h 1028190 
  /trunk/KDE/kdelibs/plasma/corona.cpp 1028190 
  /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1028190 

Diff: http://reviewboard.kde.org/r/1428/diff


Testing (updated)
-------

Tested for vertical and horizontal form factors and for floating applets.


Thanks,

Michal

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]