[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma + Nepomuk - libplasma patch - attempt 1
From:       "Ivan Cukic" <ivan.cukic+kde () gmail ! com>
Date:       2009-09-25 18:58:23
Message-ID: 20090925185823.18098.3291 () localhost
[Download RAW message or body]



> On 2009-09-23 21:28:50, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/context.h, line 78
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11891#file11891line78>
> > 
> > or perhaps:
> > 
> > forActivity(id)->setActiveContext(true);?
> > 
> 
> wrote:
> This looks appealing. The problem is that the setActiveContext would have to \
> trigger the context/activity changed signal in the manager. 
> wrote:
> that can be done behind the scenes quite easily. i'm thinking more about the public \
> API here rather than the implementation; we often make some parts of the internal \
> implementation a little "uglier" so that the public API is more consistent and \
> pretty. 
> wrote:
> OK. The second question is what to do on setActiveContext(false) - it could make no \
> activity active? I'd rather have setActive without parameters. 
> BTW, wouldn't it be a bit redundant to have Context::setActiveContext() instead of \
> only Context::setActive() (widgets have setFocus and not setFocusWidget)

since we have setCurrentActivity(), setActive() would be strange, while I still don't \
like setActiveContext() since it implies setting the context for the context.

What about activate(bool ...) ?


> On 2009-09-23 21:28:50, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/context.h, line 83
> > <http://reviewboard.kde.org/r/1699/diff/1/?file=11891#file11891line83>
> > 
> > is this equivalent to currentContext()->name()?
> 
> wrote:
> hm... Context doesn't have a name. Containment has, and it can be different - if \
> the activity name is empty, the Containment name is some generic string \
> (Desktop/Panel...) 
> wrote:
> the name of a Context should be the name associated with the Activity, if any, \
> correct? i don't think we should think too much bout Containment is doing (other \
> than we want to map Containment <-> Context) 
> wrote:
> Ok, so introducing the Context::name()

p.s. currentActivity returns ID, not name, but I've introduced Context::name()


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1699/#review2433
-----------------------------------------------------------


On 2009-09-23 20:19:36, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1699/
> -----------------------------------------------------------
> 
> (Updated 2009-09-23 20:19:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Nepomuk-based storage of plasma activities
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1027137 
> /trunk/KDE/kdelibs/plasma/applet.cpp 1027137 
> /trunk/KDE/kdelibs/plasma/containment.h 1027137 
> /trunk/KDE/kdelibs/plasma/containment.cpp 1027137 
> /trunk/KDE/kdelibs/plasma/context.h 1027137 
> /trunk/KDE/kdelibs/plasma/context.cpp 1027137 
> /trunk/KDE/kdelibs/plasma/private/activitieshandler.h PRE-CREATION 
> /trunk/KDE/kdelibs/plasma/private/activitieshandler.cpp PRE-CREATION 
> /trunk/KDE/kdelibs/plasma/private/context_p.h PRE-CREATION 
> /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1027137 
> /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.h PRE-CREATION 
> /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.cpp PRE-CREATION 
> /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.h PRE-CREATION 
> /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1699/diff
> 
> 
> Testing
> -------
> 
> Needs more testing
> 
> 
> Thanks,
> 
> Ivan
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]