[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasma + Nepomuk - libplasma patch - attempt 1
From: "Marco Martin" <notmart () gmail ! com>
Date: 2009-09-23 22:01:04
Message-ID: 20090923220104.16347.59117 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1699/#review2439
-----------------------------------------------------------
it's late here... just two quick things came to my mind :)
/trunk/KDE/kdelibs/plasma/containment.cpp
<http://reviewboard.kde.org/r/1699/#comment1761>
is the name given now by the desktop settings dialog going to be an identifier rather than a name?
seems qute a behavioural change for this function
/trunk/KDE/kdelibs/plasma/private/activitieshandler.h
<http://reviewboard.kde.org/r/1699/#comment1763>
maybe should be done with a bool activityExists() function+createactivity?
but this shortcut could be handy anyways, hmm...
a check function would make sense anyways tough
- Marco
On 2009-09-23 20:19:36, Ivan Cukic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1699/
> -----------------------------------------------------------
>
> (Updated 2009-09-23 20:19:36)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Nepomuk-based storage of plasma activities
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1027137
> /trunk/KDE/kdelibs/plasma/applet.cpp 1027137
> /trunk/KDE/kdelibs/plasma/containment.h 1027137
> /trunk/KDE/kdelibs/plasma/containment.cpp 1027137
> /trunk/KDE/kdelibs/plasma/context.h 1027137
> /trunk/KDE/kdelibs/plasma/context.cpp 1027137
> /trunk/KDE/kdelibs/plasma/private/activitieshandler.h PRE-CREATION
> /trunk/KDE/kdelibs/plasma/private/activitieshandler.cpp PRE-CREATION
> /trunk/KDE/kdelibs/plasma/private/context_p.h PRE-CREATION
> /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1027137
> /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.h PRE-CREATION
> /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.cpp PRE-CREATION
> /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.h PRE-CREATION
> /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.cpp PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1699/diff
>
>
> Testing
> -------
>
> Needs more testing
>
>
> Thanks,
>
> Ivan
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic