[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: adding default colors format for kolourpicker and
From:       "Tomaz Canabrava" <tcanabrava () kde ! org>
Date:       2009-09-21 13:01:01
Message-ID: 20090921130101.28250.94366 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1669/
-----------------------------------------------------------

(Updated 2009-09-21 13:01:00.808581)


Review request for Plasma.


Changes
-------

fixed code style, added a separator for the latex option.


Summary
-------

remvoes the default menu that appears whenever we want to pick a color, not it uses a \
default colorstring format to do that, the color string format should be choosen \
before picking colors ( click on the round color button, go to Default Color Format \
and choose your favorite one), then just pick colors without the annoying menu \
popping everytime.

Also, added support for latex colors.


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.h 1026319 
  /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp 1026319 

Diff: http://reviewboard.kde.org/r/1669/diff


Testing
-------

everything working, no regressions found, no new bugs introduced ( from my tests )


Thanks,

Tomaz

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]